From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Andrew Burgess <aburgess@broadcom.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove use of deprecated_init_ui_hook from quit_confirm.
Date: Fri, 06 Sep 2013 13:44:00 -0000 [thread overview]
Message-ID: <5229DC28.20401@redhat.com> (raw)
In-Reply-To: <838uzam69j.fsf@gnu.org>
On 09/06/2013 02:25 PM, Eli Zaretskii wrote:
> So it looks like the allegedly Windows-specific quit message is never
> used, although deprecated_init_ui_hook is non-NULL. What am I
> missing?
gdb_init is called early, and calls the _initialize routines, and also
does:
/* Allow another UI to initialize. If the UI fails to initialize,
and it wants GDB to revert to the CLI, it should clear
deprecated_init_ui_hook. */
if (deprecated_init_ui_hook)
deprecated_init_ui_hook (argv0);
And then afterwards, clear_interpreter_hooks is called:
#0 clear_interpreter_hooks () at ../../src/gdb/interps.c:371
#1 0x00000000005e4d1d in interp_set (interp=0xda7530, top_level=1) at ../../src/gdb/interps.c:195
#2 0x00000000005e68a0 in captured_main (data=0x7fffffffda50) at ../../src/gdb/main.c:868
#3 0x00000000005e34a2 in catch_errors (func=0x5e5d1e <captured_main>, func_args=0x7fffffffda50, errstring=0x8a5c54 "", mask=RETURN_MASK_ALL)
at ../../src/gdb/exceptions.c:524
#4 0x00000000005e6eda in gdb_main (args=0x7fffffffda50) at ../../src/gdb/main.c:1069
#5 0x000000000045afba in main (argc=1, argv=0x7fffffffdb58) at ../../src/gdb/gdb.c:34
And that clears the hook.
--
Pedro Alves
next prev parent reply other threads:[~2013-09-06 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 12:29 Andrew Burgess
2013-09-06 13:25 ` Eli Zaretskii
2013-09-06 13:44 ` Pedro Alves [this message]
2013-09-06 13:50 ` Eli Zaretskii
2013-09-06 14:12 ` Pedro Alves
2013-09-06 13:34 ` Pedro Alves
2013-09-09 12:15 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5229DC28.20401@redhat.com \
--to=palves@redhat.com \
--cc=aburgess@broadcom.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox