From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27996 invoked by alias); 6 Sep 2013 13:44:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27984 invoked by uid 89); 6 Sep 2013 13:44:14 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2013 13:44:14 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r86DiBTI019904 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Sep 2013 09:44:11 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r86Di9eR001789; Fri, 6 Sep 2013 09:44:09 -0400 Message-ID: <5229DC28.20401@redhat.com> Date: Fri, 06 Sep 2013 13:44:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Eli Zaretskii CC: Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [PATCH] Remove use of deprecated_init_ui_hook from quit_confirm. References: <5229CAA4.4090709@broadcom.com> <838uzam69j.fsf@gnu.org> In-Reply-To: <838uzam69j.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00235.txt.bz2 On 09/06/2013 02:25 PM, Eli Zaretskii wrote: > So it looks like the allegedly Windows-specific quit message is never > used, although deprecated_init_ui_hook is non-NULL. What am I > missing? gdb_init is called early, and calls the _initialize routines, and also does: /* Allow another UI to initialize. If the UI fails to initialize, and it wants GDB to revert to the CLI, it should clear deprecated_init_ui_hook. */ if (deprecated_init_ui_hook) deprecated_init_ui_hook (argv0); And then afterwards, clear_interpreter_hooks is called: #0 clear_interpreter_hooks () at ../../src/gdb/interps.c:371 #1 0x00000000005e4d1d in interp_set (interp=0xda7530, top_level=1) at ../../src/gdb/interps.c:195 #2 0x00000000005e68a0 in captured_main (data=0x7fffffffda50) at ../../src/gdb/main.c:868 #3 0x00000000005e34a2 in catch_errors (func=0x5e5d1e , func_args=0x7fffffffda50, errstring=0x8a5c54 "", mask=RETURN_MASK_ALL) at ../../src/gdb/exceptions.c:524 #4 0x00000000005e6eda in gdb_main (args=0x7fffffffda50) at ../../src/gdb/main.c:1069 #5 0x000000000045afba in main (argc=1, argv=0x7fffffffdb58) at ../../src/gdb/gdb.c:34 And that clears the hook. -- Pedro Alves