Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2][CRIS/CRISv32] Consistent names for cris/crisv32_elf_greg_t
Date: Tue, 03 Sep 2013 14:55:00 -0000	[thread overview]
Message-ID: <5225F849.9040203@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1309031617060.10770@lnxricardw.se.axis.com>

On 09/03/2013 03:17 PM, Ricard Wanderlof wrote:
> 
> This is just a cosmetic change to get consistent names for
> elf_greg_t/crisv32_elf_greg_t in cris-tdep.c . Compile-time tested, then
> tested the result by running the resulting gdb against gdbserver running
> on a target system.

Thanks.  It'll allow putting these types in a header too, if
ever necessary (otherwise, they'd possibly conflict with
asm/elf.h, like in the gdbserver patch).

> 2013-09-03  Ricard Wanderlof  <ricardw@axis.com>
> 
>  	* cris-tdep.c (cris_elf_greg_t): Rename from elf_greg_t.

Mention cris_elf_gregset_t, crisv32_elf_gregset_t, and all
the functions that were adjusted.  E.g.:

	* cris-tdep.c (cris_elf_greg_t): Rename from elf_greg_t.
	(cris_elf_gregset_t): Rename from elf_gregset_t.
	(crisv32_elf_gregset_t): Adjust.
	(cris_supply_gregset, fetch_core_registers): Adjust.

OK with that change.

-- 
Pedro Alves


  reply	other threads:[~2013-09-03 14:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03 14:17 Ricard Wanderlof
2013-09-03 14:55 ` Pedro Alves [this message]
2013-09-06  8:25   ` Ricard Wanderlof
2013-09-03 15:17 Ricard Wanderlof

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5225F849.9040203@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ricard.wanderlof@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox