From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29838 invoked by alias); 3 Sep 2013 14:55:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29825 invoked by uid 89); 3 Sep 2013 14:55:10 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Sep 2013 14:55:10 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r83Et61Q008375 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 Sep 2013 10:55:06 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r83Et5U5009321; Tue, 3 Sep 2013 10:55:05 -0400 Message-ID: <5225F849.9040203@redhat.com> Date: Tue, 03 Sep 2013 14:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Ricard Wanderlof CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2][CRIS/CRISv32] Consistent names for cris/crisv32_elf_greg_t References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00079.txt.bz2 On 09/03/2013 03:17 PM, Ricard Wanderlof wrote: > > This is just a cosmetic change to get consistent names for > elf_greg_t/crisv32_elf_greg_t in cris-tdep.c . Compile-time tested, then > tested the result by running the resulting gdb against gdbserver running > on a target system. Thanks. It'll allow putting these types in a header too, if ever necessary (otherwise, they'd possibly conflict with asm/elf.h, like in the gdbserver patch). > 2013-09-03 Ricard Wanderlof > > * cris-tdep.c (cris_elf_greg_t): Rename from elf_greg_t. Mention cris_elf_gregset_t, crisv32_elf_gregset_t, and all the functions that were adjusted. E.g.: * cris-tdep.c (cris_elf_greg_t): Rename from elf_greg_t. (cris_elf_gregset_t): Rename from elf_gregset_t. (crisv32_elf_gregset_t): Adjust. (cris_supply_gregset, fetch_core_registers): Adjust. OK with that change. -- Pedro Alves