From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] windows-nat.c: Don't install a deprecated_xfer_memory method.
Date: Tue, 27 Aug 2013 00:50:00 -0000 [thread overview]
Message-ID: <521BF779.5050006@codesourcery.com> (raw)
In-Reply-To: <20130823181245.4023.25651.stgit@brno.lan>
On 08/24/2013 02:12 AM, Pedro Alves wrote:
> main, so I can't imagine any regression from this. Does anyone want
> (and is willing) to run this through the testsuite?
>
Pedro,
I tested this patch on mingw native GDB. There is no regression. Note
that I also applied two local patches to make the test result usable.
1. [PATCH] Unbuffer stdout and stderr on windows (reviewed but not
approved yet.)
https://sourceware.org/ml/gdb-patches/2013-08/msg00660.html
2. A hack to set stdout and stderr to binary mode.
>
> -static int
> -windows_xfer_memory (CORE_ADDR memaddr, gdb_byte *our, int len,
> - int write, struct mem_attrib *mem,
> - struct target_ops *target)
> +static LONGEST
> +windows_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf,
> + ULONGEST memaddr, LONGEST len)
It is not installed to deprecated_xfer_memory any more, so we need
documentation on this function.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-08-27 0:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 18:12 Pedro Alves
2013-08-23 20:08 ` Joel Brobecker
2013-08-27 11:38 ` Pedro Alves
2013-08-23 21:37 ` Pierre Muller
2013-08-26 16:52 ` Pedro Alves
2013-08-26 16:54 ` Pedro Alves
2013-08-27 0:50 ` Yao Qi [this message]
2013-08-27 11:37 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521BF779.5050006@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox