From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23359 invoked by alias); 27 Aug 2013 00:50:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23350 invoked by uid 89); 27 Aug 2013 00:50:16 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Aug 2013 00:50:16 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VE7U4-0007SY-E4 from Yao_Qi@mentor.com ; Mon, 26 Aug 2013 17:50:12 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 26 Aug 2013 17:50:11 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Mon, 26 Aug 2013 17:50:11 -0700 Message-ID: <521BF779.5050006@codesourcery.com> Date: Tue, 27 Aug 2013 00:50:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH] windows-nat.c: Don't install a deprecated_xfer_memory method. References: <20130823181245.4023.25651.stgit@brno.lan> In-Reply-To: <20130823181245.4023.25651.stgit@brno.lan> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-08/txt/msg00769.txt.bz2 On 08/24/2013 02:12 AM, Pedro Alves wrote: > main, so I can't imagine any regression from this. Does anyone want > (and is willing) to run this through the testsuite? > Pedro, I tested this patch on mingw native GDB. There is no regression. Note that I also applied two local patches to make the test result usable. 1. [PATCH] Unbuffer stdout and stderr on windows (reviewed but not approved yet.) https://sourceware.org/ml/gdb-patches/2013-08/msg00660.html 2. A hack to set stdout and stderr to binary mode. > > -static int > -windows_xfer_memory (CORE_ADDR memaddr, gdb_byte *our, int len, > - int write, struct mem_attrib *mem, > - struct target_ops *target) > +static LONGEST > +windows_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf, > + ULONGEST memaddr, LONGEST len) It is not installed to deprecated_xfer_memory any more, so we need documentation on this function. -- Yao (齐尧)