Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: "Waqas, Muhammad" <Muhammad_Waqas@mentor.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] fix PR-15501
Date: Thu, 22 Aug 2013 13:41:00 -0000	[thread overview]
Message-ID: <52161505.5000909@redhat.com> (raw)
In-Reply-To: <53A5AC689E2AD547AE0EA5642E101306BB63F5@EU-MBX-04.mgc.mentorg.com>

On 08/22/2013 02:13 PM, Waqas, Muhammad wrote:

> +# Perform tests for disable/enable commands on multiple
> +# locations and breakpoints.
> +#
> +# WHAT     - the command to test (disable/enable).

That extra whitespace after WHAT was there before to align
with the other arguments.  There are no other arguments now,
so write:

# WHAT - the command to test (disable/enable).

> +    if { "$what" == "enable" } {
> +	# Set variable values for enable command.
> +	set oppos "disable"
> +	set oppos_res "n"
> +	set what_res "y"
> +	set p1 "fail"
> +	set p2 "pass"
> +

Spurious extra line.

> +    }
> +
> +    # Now enable(disable) $b.1 $b2.1.
> +    gdb_test_no_output "$what $b1.1 $b2.1" "$what \$b1.1 \$b2.1"
> +    set test1 "${what}d \$b1.1 and \$b2.1"
> +
> +    # Now $b1.1 and $b2.1 should be enabled(disabled)

Missing period.  (Most other sentences had it.)

> +
> +    # Now $b4 $b3.1 should be enabled(disabled) and
> +    # $b3 should remain disabled(enabled)

Ditto.

OK with those changes.  Thanks!

As the final patch will have changes, please commit, and
still repost it.

-- 
Pedro Alves


  reply	other threads:[~2013-08-22 13:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-13 10:03 Muhammad Waqas
2013-08-13 17:37 ` Pedro Alves
2013-08-15 10:32   ` Muhammad Waqas
2013-08-19 15:28     ` Pedro Alves
2013-08-20  6:45       ` Waqas, Muhammad
2013-08-21 22:17     ` Pedro Alves
2013-08-22  9:36       ` Waqas, Muhammad
     [not found]         ` <5215FDBE.1060209@redhat.com>
2013-08-22 13:13           ` Waqas, Muhammad
2013-08-22 13:41             ` Pedro Alves [this message]
2013-08-23  7:27               ` Muhammad Waqas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52161505.5000909@redhat.com \
    --to=palves@redhat.com \
    --cc=Muhammad_Waqas@mentor.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox