From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20534 invoked by alias); 22 Aug 2013 13:41:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20520 invoked by uid 89); 22 Aug 2013 13:41:30 -0000 X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 22 Aug 2013 13:41:29 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7MDfRsi005403 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 22 Aug 2013 09:41:27 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7MDfQYO011142; Thu, 22 Aug 2013 09:41:26 -0400 Message-ID: <52161505.5000909@redhat.com> Date: Thu, 22 Aug 2013 13:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Waqas, Muhammad" CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] fix PR-15501 References: <520A0453.4070309@codesourcery.com> <520A6EEB.8010808@redhat.com> <520CAE24.7050301@codesourcery.com>,<52153C74.7080708@redhat.com> <53A5AC689E2AD547AE0EA5642E101306BB6120@EU-MBX-04.mgc.mentorg.com>,<5215FDBE.1060209@redhat.com> <53A5AC689E2AD547AE0EA5642E101306BB63F5@EU-MBX-04.mgc.mentorg.com> In-Reply-To: <53A5AC689E2AD547AE0EA5642E101306BB63F5@EU-MBX-04.mgc.mentorg.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00635.txt.bz2 On 08/22/2013 02:13 PM, Waqas, Muhammad wrote: > +# Perform tests for disable/enable commands on multiple > +# locations and breakpoints. > +# > +# WHAT - the command to test (disable/enable). That extra whitespace after WHAT was there before to align with the other arguments. There are no other arguments now, so write: # WHAT - the command to test (disable/enable). > + if { "$what" == "enable" } { > + # Set variable values for enable command. > + set oppos "disable" > + set oppos_res "n" > + set what_res "y" > + set p1 "fail" > + set p2 "pass" > + Spurious extra line. > + } > + > + # Now enable(disable) $b.1 $b2.1. > + gdb_test_no_output "$what $b1.1 $b2.1" "$what \$b1.1 \$b2.1" > + set test1 "${what}d \$b1.1 and \$b2.1" > + > + # Now $b1.1 and $b2.1 should be enabled(disabled) Missing period. (Most other sentences had it.) > + > + # Now $b4 $b3.1 should be enabled(disabled) and > + # $b3 should remain disabled(enabled) Ditto. OK with those changes. Thanks! As the final patch will have changes, please commit, and still repost it. -- Pedro Alves