Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [patch] Fix PR cli/15842
@ 2013-08-16 10:31 Phil Muldoon
  2013-08-16 10:38 ` Pedro Alves
  2013-08-16 14:13 ` Tom Tromey
  0 siblings, 2 replies; 4+ messages in thread
From: Phil Muldoon @ 2013-08-16 10:31 UTC (permalink / raw)
  To: gdb-patches


This patch fixes a regression introduced by me when adding further
help text prompts.  It forced the symbol reading prompt ".." onto a
newline when GDB is started with a an inferior.  The fix just removes
the erroneous newline my previous patch introduced.

Tested on Fedora 17, x86_64.

OK to commit?

Cheers,

Phil

2013-08-16  Phil Muldoon  <pmuldoon@redhat.com>

	* top.c (print_gdb_version): Remove erroneous newline after help
	text.

--

diff --git a/gdb/top.c b/gdb/top.c
index 516ffb9..bb71263 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1153,7 +1153,7 @@ Type \"show configuration\" for configuration details.");
 resources online at:\n<http://www.gnu.org/software/gdb/documentation/>.\n"));
   fprintf_filtered (stream, _("For help, type \"help\".\n"));
   fprintf_filtered (stream, _("Type \"apropos word\" to search for \
-commands related to \"word\".\n"));
+commands related to \"word\"."));
 }
 
 /* Print the details of GDB build-time configuration.  */


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] Fix PR cli/15842
  2013-08-16 10:31 [patch] Fix PR cli/15842 Phil Muldoon
@ 2013-08-16 10:38 ` Pedro Alves
  2013-08-16 14:13 ` Tom Tromey
  1 sibling, 0 replies; 4+ messages in thread
From: Pedro Alves @ 2013-08-16 10:38 UTC (permalink / raw)
  To: Phil Muldoon; +Cc: gdb-patches

On 08/16/2013 11:31 AM, Phil Muldoon wrote:

> 2013-08-16  Phil Muldoon  <pmuldoon@redhat.com>
> 
> 	* top.c (print_gdb_version): Remove erroneous newline after help
> 	text.

OK, thanks.

-- 
Pedro Alves


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] Fix PR cli/15842
  2013-08-16 10:31 [patch] Fix PR cli/15842 Phil Muldoon
  2013-08-16 10:38 ` Pedro Alves
@ 2013-08-16 14:13 ` Tom Tromey
  2013-08-29  9:10   ` Phil Muldoon
  1 sibling, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2013-08-16 14:13 UTC (permalink / raw)
  To: Phil Muldoon; +Cc: gdb-patches

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> 2013-08-16  Phil Muldoon  <pmuldoon@redhat.com>
Phil> 	* top.c (print_gdb_version): Remove erroneous newline after help
Phil> 	text.

Should mention the PR in the ChangeLog entry.

Tom


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] Fix PR cli/15842
  2013-08-16 14:13 ` Tom Tromey
@ 2013-08-29  9:10   ` Phil Muldoon
  0 siblings, 0 replies; 4+ messages in thread
From: Phil Muldoon @ 2013-08-29  9:10 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

On 16/08/13 15:13, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
> 
> Phil> 2013-08-16  Phil Muldoon  <pmuldoon@redhat.com>
> Phil> 	* top.c (print_gdb_version): Remove erroneous newline after help
> Phil> 	text.
> 
> Should mention the PR in the ChangeLog entry.

So committed with ChangeLog entry:


2013-08-29  Phil Muldoon  <pmuldoon@redhat.com>

	PR cli/15842

	* top.c (print_gdb_version): Remove erroneous newline after help
	text.

Cheers,

Phil


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-08-29  9:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-16 10:31 [patch] Fix PR cli/15842 Phil Muldoon
2013-08-16 10:38 ` Pedro Alves
2013-08-16 14:13 ` Tom Tromey
2013-08-29  9:10   ` Phil Muldoon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox