From: "Andrew Burgess" <aburgess@broadcom.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] undefined printf format crashes gdb
Date: Tue, 13 Aug 2013 16:08:00 -0000 [thread overview]
Message-ID: <520A59EB.9020404@broadcom.com> (raw)
In-Reply-To: <520A428C.2070505@redhat.com>
On 13/08/2013 3:28 PM, Pedro Alves wrote:
> On 08/13/2013 01:56 PM, Andrew Burgess wrote:
>> Current gdb HEAD:
>>
>> (gdb) printf "%#p", 0
>> ./printcmd.c:2655: internal-error: ui_printf: Assertion `*p == 'p' && *(p + 1) == '\0'' failed.
>> A problem internal to GDB has been detected,
>> further debugging may prove unreliable.
>> Quit this debugging session? (y or n) y
>>
>> With my patch:
>>
>> (gdb) printf "%#p", 0
>> Inappropriate modifiers to format specifier 'p' in printf
>>
>> The man page for printf (on my machine) says # on pointers is undefined,
>> but my undefined seems better than the current undefined :)
>>
>> OK to apply?
>
> OK.
>
Committed.
Thanks,
Andrew
prev parent reply other threads:[~2013-08-13 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 12:57 Andrew Burgess
2013-08-13 14:28 ` Pedro Alves
2013-08-13 16:08 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520A59EB.9020404@broadcom.com \
--to=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox