From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17367 invoked by alias); 13 Aug 2013 16:08:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17353 invoked by uid 89); 13 Aug 2013 16:08:26 -0000 X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 Received: from mms3.broadcom.com (HELO mms3.broadcom.com) (216.31.210.19) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 13 Aug 2013 16:08:25 +0000 Received: from [10.9.208.53] by mms3.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Tue, 13 Aug 2013 08:58:12 -0700 X-Server-Uuid: B86B6450-0931-4310-942E-F00ED04CA7AF Received: from IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) by IRVEXCHCAS06.corp.ad.broadcom.com (10.9.208.53) with Microsoft SMTP Server (TLS) id 14.1.438.0; Tue, 13 Aug 2013 09:08:13 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) with Microsoft SMTP Server id 14.1.438.0; Tue, 13 Aug 2013 09:08:12 -0700 Received: from [10.177.73.61] (unknown [10.177.73.61]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 81805F2D72 for ; Tue, 13 Aug 2013 09:08:12 -0700 (PDT) Message-ID: <520A59EB.9020404@broadcom.com> Date: Tue, 13 Aug 2013 16:08:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: Re: [PATCH] undefined printf format crashes gdb References: <520A2D08.4080600@broadcom.com> <520A428C.2070505@redhat.com> In-Reply-To: <520A428C.2070505@redhat.com> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00351.txt.bz2 On 13/08/2013 3:28 PM, Pedro Alves wrote: > On 08/13/2013 01:56 PM, Andrew Burgess wrote: >> Current gdb HEAD: >> >> (gdb) printf "%#p", 0 >> ./printcmd.c:2655: internal-error: ui_printf: Assertion `*p == 'p' && *(p + 1) == '\0'' failed. >> A problem internal to GDB has been detected, >> further debugging may prove unreliable. >> Quit this debugging session? (y or n) y >> >> With my patch: >> >> (gdb) printf "%#p", 0 >> Inappropriate modifiers to format specifier 'p' in printf >> >> The man page for printf (on my machine) says # on pointers is undefined, >> but my undefined seems better than the current undefined :) >> >> OK to apply? > > OK. > Committed. Thanks, Andrew