From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/4] add caching procs to test suite
Date: Fri, 02 Aug 2013 17:23:00 -0000 [thread overview]
Message-ID: <51FBEB12.2060308@redhat.com> (raw)
In-Reply-To: <8738qsdoo3.fsf@fleche.redhat.com>
On 08/02/2013 05:48 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> On 08/02/2013 04:36 PM, Tom Tromey wrote:
>>> - set src complex[pid].c
>>> - set exe complex[pid].x
>>> + set src [standard_temp_file complex[pid].c]
>>> + set exe [standard_temp_file complex[pid].x]
>
> Pedro> Hmm. Are these uses of standard_temp_file really
> Pedro> related to the caching mechanism?
>
> Not really. I can push them into patch 2 if you want.
I always prefer logically independent changes split into
independent patches, as it makes it much easier to
understand a patch and its ramifications (post-checkin too, when
doing archaelogy and regression culprit finding), but I don't
want to insist.
--
Pedro Alves
next prev parent reply other threads:[~2013-08-02 17:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 15:36 [PATCH v2 0/4] introduce test suite "parallel" mode Tom Tromey
2013-08-02 15:36 ` [PATCH v2 4/4] introduce parallel mode Tom Tromey
2013-08-02 18:01 ` Eli Zaretskii
2013-08-02 18:37 ` Tom Tromey
2013-08-02 18:44 ` Eli Zaretskii
2013-08-02 18:48 ` Tom Tromey
2013-08-02 19:17 ` Eli Zaretskii
2013-08-02 19:19 ` Tom Tromey
2013-08-02 19:38 ` Eli Zaretskii
2013-08-02 15:36 ` [PATCH v2 2/4] add standard_temp_file Tom Tromey
2013-08-02 15:36 ` [PATCH v2 3/4] add caching procs to test suite Tom Tromey
2013-08-02 15:53 ` Pedro Alves
2013-08-02 16:48 ` Tom Tromey
2013-08-02 17:23 ` Pedro Alves [this message]
2013-08-02 20:15 ` Tom Tromey
2013-08-02 15:36 ` [PATCH v2 1/4] more uses of standard_output_file Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FBEB12.2060308@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox