From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14564 invoked by alias); 2 Aug 2013 17:23:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14537 invoked by uid 89); 2 Aug 2013 17:23:39 -0000 X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 02 Aug 2013 17:23:39 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r72HNWTd011008 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 2 Aug 2013 13:23:32 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r72HNULH023565; Fri, 2 Aug 2013 13:23:31 -0400 Message-ID: <51FBEB12.2060308@redhat.com> Date: Fri, 02 Aug 2013 17:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 3/4] add caching procs to test suite References: <1375457773-863-1-git-send-email-tromey@redhat.com> <1375457773-863-4-git-send-email-tromey@redhat.com> <51FBD5E2.5000707@redhat.com> <8738qsdoo3.fsf@fleche.redhat.com> In-Reply-To: <8738qsdoo3.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00090.txt.bz2 On 08/02/2013 05:48 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> On 08/02/2013 04:36 PM, Tom Tromey wrote: >>> - set src complex[pid].c >>> - set exe complex[pid].x >>> + set src [standard_temp_file complex[pid].c] >>> + set exe [standard_temp_file complex[pid].x] > > Pedro> Hmm. Are these uses of standard_temp_file really > Pedro> related to the caching mechanism? > > Not really. I can push them into patch 2 if you want. I always prefer logically independent changes split into independent patches, as it makes it much easier to understand a patch and its ramifications (post-checkin too, when doing archaelogy and regression culprit finding), but I don't want to insist. -- Pedro Alves