Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] Add options to skip unavailable locals
Date: Thu, 01 Aug 2013 13:59:00 -0000	[thread overview]
Message-ID: <51FA69AA.6050805@codesourcery.com> (raw)
In-Reply-To: <51FA557F.5@redhat.com>

On 08/01/2013 08:33 PM, Pedro Alves wrote:
>> +	      if (skip_unavailable
>> >+		  && (value_entirely_unavailable (val)
>> >+		      /* A scalar object that does not have all bits
>> >+			 available is also considered unavailable,
>> >+			 because all bits contribute to its
>> >+			 representation.  */
>> >+		      || (val_print_scalar_type_p (value_type (val))
>> >+			  && !value_bytes_available (val,
>> >+						     value_embedded_offset (val),
>> >+						     TYPE_LENGTH (value_type (val))))))
>> >+		;
>> >+	      else
> I don't think this has been updated right for entry values.  With
> entry values, we now have_two_  values to account for.  I think
> we need to do this once for each of the regular arg and the
> entry arg?
>

OK, will update the patch to handle both regular arg and entry value.

Is it possible that one is available and the other is not?  If yes, 
when option '--skip-unavailable' is used, some thing we have to think about,

1. if regular arg is available but entry is unavailable, like this,

 
{name="j",type="int",value="4"},{name="j@entry",type="int",value="<unavailable>"}

what is the expected output?  how about displaying regular arg only as 
it is available? like:

   {name="j",type="int",value="4"}

2. if entry is available but regular arg is not, like this,

 
{name="j",type="int",value="<unavailable>"},{name="j@entry",type="int",value="4"}

what is the expected output? how about displaying entry value only as it 
is available? like:

   {name="j@entry",type="int",value="4"}

-- 
Yao (齐尧)


  reply	other threads:[~2013-08-01 13:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-03  1:48 [PATCH 0/2] New option --skip-unavailable to -stack-list-XXX commands Yao Qi
2013-07-03  1:48 ` [PATCH 1/2] Use mi_getopt in mi_cmd_stack_list_locals and mi_cmd_stack_list_variables Yao Qi
2013-07-29 18:17   ` Pedro Alves
2013-07-31  7:01     ` Yao Qi
2013-07-31 12:23       ` Pedro Alves
2013-08-01  6:45         ` Yao Qi
2013-07-03  1:48 ` [PATCH 2/2] Add options to skip unavailable locals Yao Qi
2013-07-03  4:14   ` asmwarrior
2013-07-03  5:21     ` Yao Qi
2013-07-03 19:22   ` Eli Zaretskii
2013-07-22  1:38     ` Yao Qi
2013-08-01 12:33       ` Pedro Alves
2013-08-01 13:59         ` Yao Qi [this message]
2013-08-01 14:47           ` Pedro Alves
2013-08-25  3:43         ` [PATCH 0/2 v2] " Yao Qi
2013-08-25  3:43           ` [PATCH 1/2] Use mi_getopt_silent Yao Qi
2013-08-26  8:58             ` Agovic, Sanimir
2013-08-26 10:18               ` Yao Qi
2013-08-26 16:01                 ` Pedro Alves
2013-08-26 16:22             ` Pedro Alves
2013-08-27  3:30               ` Yao Qi
2013-08-27 11:43                 ` Pedro Alves
2013-08-25  3:43           ` [PATCH 2/2] Add options to skip unavailable locals Yao Qi
2013-08-26 16:40             ` Pedro Alves
2013-08-27  5:22               ` Yao Qi
2013-07-29  9:33 ` [ping]: [PATCH 0/2] New option --skip-unavailable to -stack-list-XXX commands Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FA69AA.6050805@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox