From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10845 invoked by alias); 1 Aug 2013 13:59:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10834 invoked by uid 89); 1 Aug 2013 13:59:54 -0000 X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_50,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 01 Aug 2013 13:59:54 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1V4tPu-0006QW-58 from Yao_Qi@mentor.com ; Thu, 01 Aug 2013 06:59:46 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 1 Aug 2013 06:59:45 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Thu, 1 Aug 2013 06:59:45 -0700 Message-ID: <51FA69AA.6050805@codesourcery.com> Date: Thu, 01 Aug 2013 13:59:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pedro Alves CC: Eli Zaretskii , Subject: Re: [PATCH 2/2] Add options to skip unavailable locals References: <1372816106-15942-1-git-send-email-yao@codesourcery.com> <1372816106-15942-3-git-send-email-yao@codesourcery.com> <83vc4ra1ps.fsf@gnu.org> <51EC8CCE.7020007@codesourcery.com> <51FA557F.5@redhat.com> In-Reply-To: <51FA557F.5@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-08/txt/msg00024.txt.bz2 On 08/01/2013 08:33 PM, Pedro Alves wrote: >> + if (skip_unavailable >> >+ && (value_entirely_unavailable (val) >> >+ /* A scalar object that does not have all bits >> >+ available is also considered unavailable, >> >+ because all bits contribute to its >> >+ representation. */ >> >+ || (val_print_scalar_type_p (value_type (val)) >> >+ && !value_bytes_available (val, >> >+ value_embedded_offset (val), >> >+ TYPE_LENGTH (value_type (val)))))) >> >+ ; >> >+ else > I don't think this has been updated right for entry values. With > entry values, we now have_two_ values to account for. I think > we need to do this once for each of the regular arg and the > entry arg? > OK, will update the patch to handle both regular arg and entry value. Is it possible that one is available and the other is not? If yes, when option '--skip-unavailable' is used, some thing we have to think about, 1. if regular arg is available but entry is unavailable, like this, {name="j",type="int",value="4"},{name="j@entry",type="int",value=""} what is the expected output? how about displaying regular arg only as it is available? like: {name="j",type="int",value="4"} 2. if entry is available but regular arg is not, like this, {name="j",type="int",value=""},{name="j@entry",type="int",value="4"} what is the expected output? how about displaying entry value only as it is available? like: {name="j@entry",type="int",value="4"} -- Yao (齐尧)