Re: [PATCH 2/4] Remove deprecated_throw_reason from mips_error.

[Pedro Alves <palves@redhat.com>]

On 07/30/2013 05:11 PM, Andrew Burgess wrote:
> Removes use of deprecated_throw_reason from mips_error.  The user will now
> see the extra "Remote debugging terminated" error message but that doesn't
> feel too bad to me, what do you think?
> 
> OK to apply?
> 
> Thanks,
> Andrew
> 
> gdb/ChangeLog
> 
> 2013-07-30  Andrew Burgess  <aburgess@broadcom.com>
> 
> 	* remote-mips.c (mips_error): Replace use of deprecated_throw_reason
> 	with throw_error.
> 
> diff --git a/gdb/remote-mips.c b/gdb/remote-mips.c
> index 1619622..791aa8a 100644
> --- a/gdb/remote-mips.c
> +++ b/gdb/remote-mips.c
> @@ -510,7 +510,7 @@ mips_error (char *string,...)
>    if (!ptid_equal (inferior_ptid, null_ptid))
>      target_mourn_inferior ();
>  
> -  deprecated_throw_reason (RETURN_ERROR);
> +  throw_error (GENERIC_ERROR, "Remote debugging terminated");

Throw TARGET_CLOSE_ERROR instead.  Add i18n, and period at end
of sentence.  Okay with that change.

I'd suggest removing or merging the earlier printf_unfiltered with
the error message, they're a bit redundant, and having the text
in the error is better in that a frontend usually displays errors
in a special way (a messagebox or some such), while console prints
end up hidden in the console...

-- 
Pedro Alves