From: "Andrew Burgess" <aburgess@broadcom.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 3/4] Remove remaining uses of deprecated_throw_reason.
Date: Tue, 30 Jul 2013 16:12:00 -0000 [thread overview]
Message-ID: <51F7E5D3.5010300@broadcom.com> (raw)
In-Reply-To: <51F7E51E.3070807@broadcom.com>
This removes the final uses of deprecated_throw_reason. In each case I've
replaced the use of deprecated_throw_reason with a call to quit. The only
change this will have is that the user will now see a "Quit" message,
however this seems pretty appropriate to me, what do you think?
OK to apply?
Thanks,
Andrew
gdb/ChangeLog
2013-07-30 Andrew Burgess <aburgess@broadcom.com>
* monitor.c (monitor_interrupt_query): Replace use of
deprecated_throw_reason with quit.
* nto-procfs.c (interrupt_query): Likewise.
* remote-fileio.c (remote_fileio_sig_exit): Likewise.
* remote-mips.c (mips_kill): Likewise.
* remote.c (interrupt_query): Likewise.
diff --git a/gdb/monitor.c b/gdb/monitor.c
index beca4e4..0e47acc 100644
--- a/gdb/monitor.c
+++ b/gdb/monitor.c
@@ -1036,7 +1036,7 @@ monitor_interrupt_query (void)
Give up (and stop debugging it)? ")))
{
target_mourn_inferior ();
- deprecated_throw_reason (RETURN_QUIT);
+ quit ();
}
target_terminal_inferior ();
diff --git a/gdb/nto-procfs.c b/gdb/nto-procfs.c
index 0c2d3a8..5109fac 100644
--- a/gdb/nto-procfs.c
+++ b/gdb/nto-procfs.c
@@ -694,7 +694,7 @@ interrupt_query (void)
Give up (and stop debugging it)? ")))
{
target_mourn_inferior ();
- deprecated_throw_reason (RETURN_QUIT);
+ quit ();
}
target_terminal_inferior ();
diff --git a/gdb/remote-fileio.c b/gdb/remote-fileio.c
index cc39bdf..5b7ef1d 100644
--- a/gdb/remote-fileio.c
+++ b/gdb/remote-fileio.c
@@ -513,7 +513,7 @@ remote_fileio_sig_exit (void)
static void
async_remote_fileio_interrupt (gdb_client_data arg)
{
- deprecated_throw_reason (RETURN_QUIT);
+ quit ();
}
static void
diff --git a/gdb/remote-mips.c b/gdb/remote-mips.c
index 1619622..791aa8a 100644
--- a/gdb/remote-mips.c
+++ b/gdb/remote-mips.c
@@ -2293,8 +2293,7 @@ Give up (and stop debugging it)? ")))
printf_unfiltered ("Ending remote MIPS debugging.\n");
target_mourn_inferior ();
-
- deprecated_throw_reason (RETURN_QUIT);
+ quit ();
}
target_terminal_inferior ();
diff --git a/gdb/remote.c b/gdb/remote.c
index 1d6ac90..7830e67 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -5165,7 +5165,7 @@ interrupt_query (void)
if (target_can_async_p ())
{
signal (SIGINT, handle_sigint);
- deprecated_throw_reason (RETURN_QUIT);
+ quit ();
}
else
{
@@ -5173,7 +5173,7 @@ interrupt_query (void)
Give up (and stop debugging it)? ")))
{
remote_unpush_target ();
- deprecated_throw_reason (RETURN_QUIT);
+ quit ();
}
}
next prev parent reply other threads:[~2013-07-30 16:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 16:09 [PATCH 0/4] Remove deprecated_throw_reason Andrew Burgess
2013-07-30 16:10 ` [PATCH 1/4] Remove deprecated_throw_reason from internal_verror Andrew Burgess
2013-07-30 19:08 ` Pedro Alves
2013-07-31 10:52 ` Andrew Burgess
2013-07-30 16:11 ` [PATCH 2/4] Remove deprecated_throw_reason from mips_error Andrew Burgess
2013-07-30 19:14 ` Pedro Alves
2013-07-31 12:37 ` Andrew Burgess
2013-07-31 14:44 ` Pedro Alves
2013-07-31 15:37 ` Andrew Burgess
2013-07-30 16:12 ` Andrew Burgess [this message]
2013-07-30 19:21 ` [PATCH 3/4] Remove remaining uses of deprecated_throw_reason Pedro Alves
2013-07-31 12:45 ` Andrew Burgess
2013-07-30 16:13 ` [PATCH 4/4] Remove deprecated_throw_reason Andrew Burgess
2013-07-30 19:22 ` Pedro Alves
2013-07-31 15:45 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F7E5D3.5010300@broadcom.com \
--to=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox