From: Muhammad Bilal <mbilal@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH PR gdb/15715] 'set history filename' to by immediately converted to absolute path.
Date: Tue, 30 Jul 2013 12:11:00 -0000 [thread overview]
Message-ID: <51F7AD63.4080404@codesourcery.com> (raw)
In-Reply-To: <51F79CB0.4040809@redhat.com>
On 07/30/2013 04:00 PM, Pedro Alves wrote:
> On 07/30/2013 11:46 AM, Muhammad Bilal wrote:
>
>> 2012-07-30 Muhammad Bilal <mbilal@codesorcery.com>
>>
>> PR gdb/15715
>> * top.c: Include "filenames.h".
>> (set_history_filename): New function.
>> (init_main): Install it as set hook of the "set history filename"
>> command.
>>
>> /testsuit
>> 2012-07-30 Muhammad Bilal <mbilal@codesourcery.com>
>>
>> PR gdb/15715
>> * gdb.base/setshow.exp: Test that relative paths passed to
>> 'set history filename' are converted to absolute paths
> You've lost the period at end of this sentence. It was there in
> previous versions. I'd like to be sure you learn to pay attention to
> these details, hence the multiple iterations, but I'd like to avoid
> having to go through them for all patches. Please be attentive. This
> is OK with the missing period added (though as penance, I really should
> have you go through one more round of posting before approving. ;-) )
>
committed
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/top.c.diff?cvsroot=src&r1=1.239&r2=1.240
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15844&r2=1.15845
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/setshow.exp.diff?cvsroot=src&r1=1.33&r2=1.34
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.3748&r2=1.3749
Thanks,
-Bilal
prev parent reply other threads:[~2013-07-30 12:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <97B73E257CC18646B0B5D3DD77DCBDD15DA063@EU-MBX-02.mgc.mentorg.com>
2013-07-12 11:05 ` Bilal, Muhammad
2013-07-19 10:22 ` Muhammad Bilal
2013-07-26 5:13 ` Muhammad Bilal
2013-07-26 12:49 ` Pedro Alves
2013-07-29 6:12 ` Muhammad Bilal
2013-07-29 14:43 ` Pedro Alves
2013-07-30 9:56 ` Muhammad Bilal
2013-07-30 10:09 ` Pedro Alves
2013-07-30 10:47 ` Muhammad Bilal
2013-07-30 11:33 ` Pedro Alves
2013-07-30 12:11 ` Muhammad Bilal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F7AD63.4080404@codesourcery.com \
--to=mbilal@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox