From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31067 invoked by alias); 30 Jul 2013 12:11:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31047 invoked by uid 89); 30 Jul 2013 12:11:22 -0000 X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_20,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 30 Jul 2013 12:11:21 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1V48ll-00010t-Hi from Muhammad_Bilal@mentor.com ; Tue, 30 Jul 2013 05:11:13 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 30 Jul 2013 05:11:13 -0700 Received: from [137.202.157.37] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Tue, 30 Jul 2013 13:11:12 +0100 Message-ID: <51F7AD63.4080404@codesourcery.com> Date: Tue, 30 Jul 2013 12:11:00 -0000 From: Muhammad Bilal User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH PR gdb/15715] 'set history filename' to by immediately converted to absolute path. References: <97B73E257CC18646B0B5D3DD77DCBDD15DA063@EU-MBX-02.mgc.mentorg.com> <97B73E257CC18646B0B5D3DD77DCBDD15DA08C@EU-MBX-02.mgc.mentorg.com> <51F27050.6060409@redhat.com> <51F607C7.7020108@codesourcery.com> <51F67A1A.8060602@redhat.com> <51F78DB7.8010902@codesourcery.com> <51F790BE.9020306@redhat.com> <51F799A2.1030500@codesourcery.com> <51F79CB0.4040809@redhat.com> In-Reply-To: <51F79CB0.4040809@redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00761.txt.bz2 On 07/30/2013 04:00 PM, Pedro Alves wrote: > On 07/30/2013 11:46 AM, Muhammad Bilal wrote: > >> 2012-07-30 Muhammad Bilal >> >> PR gdb/15715 >> * top.c: Include "filenames.h". >> (set_history_filename): New function. >> (init_main): Install it as set hook of the "set history filename" >> command. >> >> /testsuit >> 2012-07-30 Muhammad Bilal >> >> PR gdb/15715 >> * gdb.base/setshow.exp: Test that relative paths passed to >> 'set history filename' are converted to absolute paths > You've lost the period at end of this sentence. It was there in > previous versions. I'd like to be sure you learn to pay attention to > these details, hence the multiple iterations, but I'd like to avoid > having to go through them for all patches. Please be attentive. This > is OK with the missing period added (though as penance, I really should > have you go through one more round of posting before approving. ;-) ) > committed http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/top.c.diff?cvsroot=src&r1=1.239&r2=1.240 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15844&r2=1.15845 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/setshow.exp.diff?cvsroot=src&r1=1.33&r2=1.34 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.3748&r2=1.3749 Thanks, -Bilal