From: Yao Qi <yao@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix up msymbol type of dll trampoline to mst_solib_trampoline
Date: Thu, 18 Jul 2013 02:09:00 -0000 [thread overview]
Message-ID: <51E74E2D.3040806@codesourcery.com> (raw)
In-Reply-To: <87vc4igxq6.fsf@fleche.redhat.com>
On 07/11/2013 12:56 AM, Tom Tromey wrote:
> This should use ALL_OBJFILE_MSYMBOLS.
>
> I'm mildly concerned that this exposes an implementation detail of the
> minsym storage -- namely, it assumes that it is ok to modify a minsym
> after the minsym is installed.
>
Right, we had this assumption in this patch. If MSYMBOL_TYPE is used in
the computation of hash key, we can't do this after minsym is installed
(hashtab is set up).
> This approach would also block constification of the minsym API.
>
> Neither of these seem like blocking considerations though. Presumably
> bugs arising from the first would be caught in testing; and for the
> second, casting away const would be obviously ok.
>
> So, ok with the ALL_OBJFILE_MSYMBOLS change.
Thanks for the review. Change to use ALL_OBJFILE_MSYMBOLS and
regression tested again. The fail is still fixed.
-FAIL: gdb.base/solib-symbol.exp: foo in libmd
+PASS: gdb.base/solib-symbol.exp: foo in libmd
Committed.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-07-18 2:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 4:24 Yao Qi
2013-06-27 20:43 ` Tom Tromey
2013-06-28 7:37 ` Yao Qi
2013-06-28 15:58 ` Tom Tromey
2013-07-03 0:26 ` Yao Qi
2013-07-05 8:44 ` asmwarrior
2013-07-05 12:22 ` Yao Qi
2013-07-05 14:30 ` Eli Zaretskii
2013-07-06 7:21 ` Yao Qi
2013-07-06 7:41 ` Eli Zaretskii
2013-07-06 8:20 ` asmwarrior
2013-07-10 6:21 ` Yao Qi
2013-07-10 16:56 ` Tom Tromey
2013-07-18 2:09 ` Yao Qi [this message]
2013-07-18 3:26 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E74E2D.3040806@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox