From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5100 invoked by alias); 18 Jul 2013 02:09:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5074 invoked by uid 89); 18 Jul 2013 02:09:41 -0000 X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_50,KAM_STOCKGEN,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,TW_BM autolearn=no version=3.3.1 Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 18 Jul 2013 02:09:40 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Uzdeu-0002Ir-Pf from Yao_Qi@mentor.com ; Wed, 17 Jul 2013 19:09:32 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 17 Jul 2013 19:09:33 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Wed, 17 Jul 2013 19:09:32 -0700 Message-ID: <51E74E2D.3040806@codesourcery.com> Date: Thu, 18 Jul 2013 02:09:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH] Fix up msymbol type of dll trampoline to mst_solib_trampoline References: <1372043502-4618-1-git-send-email-yao@codesourcery.com> <874ncjmgkl.fsf@fleche.redhat.com> <51CD0054.9040401@codesourcery.com> <87ehbmkzqr.fsf@fleche.redhat.com> <51D36FB3.4070006@codesourcery.com> <87vc4igxq6.fsf@fleche.redhat.com> In-Reply-To: <87vc4igxq6.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-07/txt/msg00436.txt.bz2 On 07/11/2013 12:56 AM, Tom Tromey wrote: > This should use ALL_OBJFILE_MSYMBOLS. > > I'm mildly concerned that this exposes an implementation detail of the > minsym storage -- namely, it assumes that it is ok to modify a minsym > after the minsym is installed. > Right, we had this assumption in this patch. If MSYMBOL_TYPE is used in the computation of hash key, we can't do this after minsym is installed (hashtab is set up). > This approach would also block constification of the minsym API. > > Neither of these seem like blocking considerations though. Presumably > bugs arising from the first would be caught in testing; and for the > second, casting away const would be obviously ok. > > So, ok with the ALL_OBJFILE_MSYMBOLS change. Thanks for the review. Change to use ALL_OBJFILE_MSYMBOLS and regression tested again. The fail is still fixed. -FAIL: gdb.base/solib-symbol.exp: foo in libmd +PASS: gdb.base/solib-symbol.exp: foo in libmd Committed. -- Yao (齐尧)