Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Andrew Burgess" <aburgess@broadcom.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "Pedro Alves" <palves@redhat.com>
Subject: Re: [3/3] [PATCH] value_optimized_out and value_fetch_lazy
Date: Mon, 01 Jul 2013 18:06:00 -0000	[thread overview]
Message-ID: <51D1C52A.1070603@broadcom.com> (raw)
In-Reply-To: <51C1D347.3020906@redhat.com>

On 19/06/2013 4:50 PM, Pedro Alves wrote:
> On 06/10/2013 11:24 AM, Andrew Burgess wrote:
>
>> I ran into an issue with gdb that appears to be caused by an incorrect
>> use of value_optimized_out.
>>
> 
> I'm finding the patch a bit hard to read though.  Could you
> split it up?  

This tiny patch notices that when we mark a value as optimized out
we can also mark the value as no longer lazy.
This patch is not required, but felt like a good thing to me, not
sure if everyone will agree though.

Should I apply?

Thanks
Andrew




gdb/ChangeLog

2013-07-01  Andrew Burgess  <aburgess@broadcom.com>

	* value.c (set_value_optimized_out): A value that is optimized out
	is no longer lazy.

diff --git a/gdb/value.c b/gdb/value.c
index 8547590..61fd4a1 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -1061,6 +1061,8 @@ void
 set_value_optimized_out (struct value *value, int val)
 {
   value->optimized_out = val;
+  if (val)
+    set_value_lazy (value, 0);
 }
 
 int



  reply	other threads:[~2013-07-01 18:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10 12:46 Andrew Burgess
2013-06-19 15:55 ` Pedro Alves
2013-07-01 18:06   ` Andrew Burgess [this message]
2013-07-03 19:57     ` [3/3] " Pedro Alves
2013-07-04 16:41       ` Andrew Burgess
2013-07-04 17:08         ` Pedro Alves
2013-07-05  9:31           ` Pedro Alves
2013-07-05 10:56             ` Pedro Alves
2013-07-01 18:06   ` [2/3] " Andrew Burgess
2013-07-03 18:43     ` Pedro Alves
2013-07-04 11:23       ` Andrew Burgess
2013-07-01 18:06   ` [1/3] " Andrew Burgess
2013-07-03 18:42     ` Pedro Alves
2013-07-04  9:51       ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D1C52A.1070603@broadcom.com \
    --to=aburgess@broadcom.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox