From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6977 invoked by alias); 1 Jul 2013 18:06:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6963 invoked by uid 89); 1 Jul 2013 18:06:44 -0000 X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mms2.broadcom.com (HELO mms2.broadcom.com) (216.31.210.18) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 01 Jul 2013 18:06:44 +0000 Received: from [10.9.208.53] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Mon, 01 Jul 2013 11:00:44 -0700 X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS06.corp.ad.broadcom.com (10.9.208.53) with Microsoft SMTP Server (TLS) id 14.1.438.0; Mon, 1 Jul 2013 11:06:35 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Mon, 1 Jul 2013 11:06:35 -0700 Received: from [10.177.73.66] (unknown [10.177.73.66]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id E3A76F2D74; Mon, 1 Jul 2013 11:06:34 -0700 (PDT) Message-ID: <51D1C52A.1070603@broadcom.com> Date: Mon, 01 Jul 2013 18:06:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" cc: "Pedro Alves" Subject: Re: [3/3] [PATCH] value_optimized_out and value_fetch_lazy References: <51B5A95F.7090400@broadcom.com> <51C1D347.3020906@redhat.com> In-Reply-To: <51C1D347.3020906@redhat.com> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00058.txt.bz2 On 19/06/2013 4:50 PM, Pedro Alves wrote: > On 06/10/2013 11:24 AM, Andrew Burgess wrote: > >> I ran into an issue with gdb that appears to be caused by an incorrect >> use of value_optimized_out. >> > > I'm finding the patch a bit hard to read though. Could you > split it up? This tiny patch notices that when we mark a value as optimized out we can also mark the value as no longer lazy. This patch is not required, but felt like a good thing to me, not sure if everyone will agree though. Should I apply? Thanks Andrew gdb/ChangeLog 2013-07-01 Andrew Burgess * value.c (set_value_optimized_out): A value that is optimized out is no longer lazy. diff --git a/gdb/value.c b/gdb/value.c index 8547590..61fd4a1 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -1061,6 +1061,8 @@ void set_value_optimized_out (struct value *value, int val) { value->optimized_out = val; + if (val) + set_value_lazy (value, 0); } int