Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3] Exit code of exited inferiors in -list-thread-groups
Date: Tue, 25 Jun 2013 20:07:00 -0000	[thread overview]
Message-ID: <51C9F463.1010008@ericsson.com> (raw)
In-Reply-To: <51C055C7.90506@redhat.com>

On 13-06-18 08:42 AM, Pedro Alves wrote:
>> gdb/doc/ChangeLog:
>> 2013-06-17  Simon Marchi <simon.marchi@ericsson.com>
>>
>>     * gdb.texinfo: Document new exit-code field.
> 
> This should mention the node name in the bit that goes
> in ()'s.  See existing examples.  It should also mention
> -list-thread-groups.

Ok, so it would look like:

2013-06-25  Simon Marchi <simon.marchi@ericsson.com>

	* gdb.texinfo (Miscellaneous gdb/mi Commands): Document new
	exit-code field in -list-thread-groups output.

> I went ahead and did all these changes on top of your patch, so you
> could see what I mean.  I tweaked the messages and comments a
> little.  

Thanks for that and the comments. The test looks much cleaner with these
changes.

I suppose this patch will be ready to merge once the legal process is
completed and I get the access ?


  reply	other threads:[~2013-06-25 19:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 17:57 Simon Marchi
2013-06-18 13:19 ` Pedro Alves
2013-06-25 20:07   ` Simon Marchi [this message]
2013-06-25 20:24     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C9F463.1010008@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox