Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Stan Shebs <stanshebs@earthlink.net>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 2 OF 2] extend tsave to write start and stop time into a trace file
Date: Thu, 20 Jun 2013 00:41:00 -0000	[thread overview]
Message-ID: <51C24BE6.1080403@earthlink.net> (raw)
In-Reply-To: <51B5D080.4080206@mentor.com>

On 6/10/13 6:11 AM, Dmitry Kozlov wrote:
> On 06/10/2013 05:08 PM, Hui Zhu wrote:
>> On Mon, Jun 10, 2013 at 8:47 PM, Dmitry Kozlov
>> <dmitry_kozlov@mentor.com> wrote:
>>> Hi Pedro,
>>> some time ago we already discussed these patches, could you please
>>> review
>>> them again.
>>>
>>> And this one extends tsave command to write start and stop time into a
>>> tracefile.


+      fprintf (writer->fp, ";starttime:%s",
+      phex_nz (ts->start_time, sizeof (ts->start_time)));

Please doublechecking the indent before committing, it doesn't look
right in the patch.

Otherwise, it's fine to commit, and thanks!

Stan
stan@codesourcery.com


  reply	other threads:[~2013-06-20  0:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10 13:08 Dmitry Kozlov
2013-06-10 13:11 ` Hui Zhu
2013-06-10 14:21   ` Dmitry Kozlov
2013-06-20  0:41     ` Stan Shebs [this message]
2013-06-20 15:18     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C24BE6.1080403@earthlink.net \
    --to=stanshebs@earthlink.net \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox