From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-102645-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12404 invoked by alias); 20 Jun 2013 00:25:14 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 12389 invoked by uid 89); 20 Jun 2013 00:25:13 -0000
X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD autolearn=ham version=3.3.1
Received: from elasmtp-scoter.atl.sa.earthlink.net (HELO elasmtp-scoter.atl.sa.earthlink.net) (209.86.89.67)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 20 Jun 2013 00:25:13 +0000
Received: from [68.96.200.16] (helo=macbook2.local)	by elasmtp-scoter.atl.sa.earthlink.net with esmtpa (Exim 4.67)	(envelope-from <stanshebs@earthlink.net>)	id 1UpSgZ-0002oJ-6r	for gdb-patches@sourceware.org; Wed, 19 Jun 2013 20:25:11 -0400
Message-ID: <51C24BE6.1080403@earthlink.net>
Date: Thu, 20 Jun 2013 00:41:00 -0000
From: Stan Shebs <stanshebs@earthlink.net>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 2 OF 2] extend tsave to write start and stop time into a trace file
References: <51B5CAF5.3090101@mentor.com> <CANFwon3xBZpYJMqqKYOHvEp05cBGYfMeEsGA9L0qBmVJxVSKeQ@mail.gmail.com> <51B5D080.4080206@mentor.com>
In-Reply-To: <51B5D080.4080206@mentor.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da940cc47905d4645f120035465bf54397fc0350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c
X-SW-Source: 2013-06/txt/msg00530.txt.bz2

On 6/10/13 6:11 AM, Dmitry Kozlov wrote:
> On 06/10/2013 05:08 PM, Hui Zhu wrote:
>> On Mon, Jun 10, 2013 at 8:47 PM, Dmitry Kozlov
>> <dmitry_kozlov@mentor.com> wrote:
>>> Hi Pedro,
>>> some time ago we already discussed these patches, could you please
>>> review
>>> them again.
>>>
>>> And this one extends tsave command to write start and stop time into a
>>> tracefile.


+      fprintf (writer->fp, ";starttime:%s",
+      phex_nz (ts->start_time, sizeof (ts->start_time)));

Please doublechecking the indent before committing, it doesn't look
right in the patch.

Otherwise, it's fine to commit, and thanks!

Stan
stan@codesourcery.com