From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] don't keep a gdb-specific date
Date: Wed, 19 Jun 2013 18:33:00 -0000 [thread overview]
Message-ID: <51C1F71D.9020409@redhat.com> (raw)
In-Reply-To: <1371665585-32104-1-git-send-email-tromey@redhat.com>
On 06/19/2013 07:13 PM, Tom Tromey wrote:
>
> -version.c: Makefile version.in
> - rm -f version.c-tmp version.c
> +version.c: Makefile version.in $(srcdir)/../bfd/version.h
> + rm -f version.c-tmp version.c version.tmp
> + date=`sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$$/\1/p' $(srcdir)/../bfd/version.h`; \
> + sed -e "s/DATE/$$date/" < $(srcdir)/version.in > version.tmp
> echo '#include "version.h"' >> version.c-tmp
> - echo 'const char version[] = "'"`sed q ${srcdir}/version.in`"'";' >> version.c-tmp
> + echo 'const char version[] = "'"`sed q version.tmp`"'";' >> version.c-tmp
> echo 'const char host_name[] = "$(host_alias)";' >> version.c-tmp
> echo 'const char target_name[] = "$(target_alias)";' >> version.c-tmp
> mv version.c-tmp version.c
> + rm -f version.tmp
>
> observer.h: observer.sh doc/observer.texi
> ${srcdir}/observer.sh h ${srcdir}/doc/observer.texi observer.h
> diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in
> index e8470a8..067302d 100644
> --- a/gdb/gdbserver/Makefile.in
> +++ b/gdb/gdbserver/Makefile.in
> @@ -389,12 +389,15 @@ am--refresh:
>
> force:
>
> -version.c: Makefile $(srcdir)/../version.in
> - rm -f version.c-tmp version.c
> +version.c: Makefile $(srcdir)/../version.in $(srcdir)/../../bfd/version.h
> + rm -f version.c-tmp version.c version.tmp
> + date=`sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$$/\1/p' $(srcdir)/../../bfd/version.h`; \
> + sed -e "s/DATE/$$date/" < $(srcdir)/../version.in > version.tmp
> echo '#include "server.h"' >> version.c-tmp
> - echo 'const char version[] = "'"`sed q ${srcdir}/../version.in`"'";' >> version.c-tmp
> + echo 'const char version[] = "'"`sed q version.tmp`"'";' >> version.c-tmp
> echo 'const char host_name[] = "$(host_alias)";' >> version.c-tmp
> mv version.c-tmp version.c
> + rm -f version.tmp
> version.o: version.c $(server_h)
Looks fine now, thanks.
How about we move version.* to common/ ?
--
Pedro Alves
next prev parent reply other threads:[~2013-06-19 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 18:23 Tom Tromey
2013-06-19 18:33 ` Pedro Alves [this message]
2013-06-20 16:53 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C1F71D.9020409@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox