From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12036 invoked by alias); 19 Jun 2013 18:23:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12026 invoked by uid 89); 19 Jun 2013 18:23:28 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 19 Jun 2013 18:23:27 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5JINQ6a011171 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 19 Jun 2013 14:23:26 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5JINPHq021500; Wed, 19 Jun 2013 14:23:25 -0400 Message-ID: <51C1F71D.9020409@redhat.com> Date: Wed, 19 Jun 2013 18:33:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2] don't keep a gdb-specific date References: <1371665585-32104-1-git-send-email-tromey@redhat.com> In-Reply-To: <1371665585-32104-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00507.txt.bz2 On 06/19/2013 07:13 PM, Tom Tromey wrote: > > -version.c: Makefile version.in > - rm -f version.c-tmp version.c > +version.c: Makefile version.in $(srcdir)/../bfd/version.h > + rm -f version.c-tmp version.c version.tmp > + date=`sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$$/\1/p' $(srcdir)/../bfd/version.h`; \ > + sed -e "s/DATE/$$date/" < $(srcdir)/version.in > version.tmp > echo '#include "version.h"' >> version.c-tmp > - echo 'const char version[] = "'"`sed q ${srcdir}/version.in`"'";' >> version.c-tmp > + echo 'const char version[] = "'"`sed q version.tmp`"'";' >> version.c-tmp > echo 'const char host_name[] = "$(host_alias)";' >> version.c-tmp > echo 'const char target_name[] = "$(target_alias)";' >> version.c-tmp > mv version.c-tmp version.c > + rm -f version.tmp > > observer.h: observer.sh doc/observer.texi > ${srcdir}/observer.sh h ${srcdir}/doc/observer.texi observer.h > diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in > index e8470a8..067302d 100644 > --- a/gdb/gdbserver/Makefile.in > +++ b/gdb/gdbserver/Makefile.in > @@ -389,12 +389,15 @@ am--refresh: > > force: > > -version.c: Makefile $(srcdir)/../version.in > - rm -f version.c-tmp version.c > +version.c: Makefile $(srcdir)/../version.in $(srcdir)/../../bfd/version.h > + rm -f version.c-tmp version.c version.tmp > + date=`sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$$/\1/p' $(srcdir)/../../bfd/version.h`; \ > + sed -e "s/DATE/$$date/" < $(srcdir)/../version.in > version.tmp > echo '#include "server.h"' >> version.c-tmp > - echo 'const char version[] = "'"`sed q ${srcdir}/../version.in`"'";' >> version.c-tmp > + echo 'const char version[] = "'"`sed q version.tmp`"'";' >> version.c-tmp > echo 'const char host_name[] = "$(host_alias)";' >> version.c-tmp > mv version.c-tmp version.c > + rm -f version.tmp > version.o: version.c $(server_h) Looks fine now, thanks. How about we move version.* to common/ ? -- Pedro Alves