[RFA PATCH v2 0/3] Add TDB regset support

[RFA PATCH v2 0/3] Add TDB regset support

[Andreas Arnez]

Thanks, Pedro and Luis, for your feedback.

Changes from the initial version:

* New target descriptions for S/390- and System z targets with the
  transactional-execution facility are added.

* An update for the NEWS file is provided.

* A new node for gdb.texinfo is provided, including a description of the
  new TDB feature.

* A bug is fixed in ppc_linux_iterate_over_regset_sections in
  ppc-linux-tdep.c, where the general-purpose registers were handled
  incorrectly on 64-bit targets.


 gdb/NEWS                                |    4 
 gdb/amd64-linux-tdep.c                  |   32 +-
 gdb/arm-linux-tdep.c                    |   35 +-
 gdb/corelow.c                           |   42 +--
 gdb/doc/gdb.texinfo                     |   38 ++
 gdb/features/Makefile                   |    3 
 gdb/features/s390-tdb.xml               |   30 ++
 gdb/features/s390-te-linux64.c          |  118 ++++++++
 gdb/features/s390-te-linux64.xml        |   25 +
 gdb/features/s390x-te-linux64.c         |  102 +++++++
 gdb/features/s390x-te-linux64.xml       |   24 +
 gdb/gdbarch.c                           |   36 +-
 gdb/gdbarch.h                           |   19 +
 gdb/gdbarch.sh                          |   12 
 gdb/gdbserver/linux-s390-low.c          |    9 
 gdb/i386-linux-tdep.c                   |   47 +--
 gdb/linux-tdep.c                        |  103 ++++---
 gdb/ppc-linux-tdep.c                    |   93 +-----
 gdb/regformats/s390-te-linux64.dat      |   94 ++++++
 gdb/regformats/s390x-te-linux64.dat     |   78 +++++
 gdb/regset.h                            |    8 
 gdb/s390-nat.c                          |  217 +++++++---------
 gdb/s390-tdep.c                         |  165 +++---------
 gdb/s390-tdep.h                         |   20 +
 gdb/testsuite/gdb.arch/s390-tdbregs.c   |   62 ++++
 gdb/testsuite/gdb.arch/s390-tdbregs.exp |   75 +++++
 s390-nat.c                              |   37 +-
 s390-tdep.c                             |  434 +++++++++++++++++---------------
 s390-tdep.h                             |   40 ++
 29 files changed, 1334 insertions(+), 668 deletions(-)

Re: [RFA PATCH v2 0/3] Add TDB regset support

[Pedro Alves]

On 06/12/2013 12:57 PM, Andreas Arnez wrote:

> Changes from the initial version:
> 
> * New target descriptions for S/390- and System z targets with the
>   transactional-execution facility are added.
>
> * An update for the NEWS file is provided.
> 
> * A new node for gdb.texinfo is provided, including a description of the
>   new TDB feature.

Great, thanks!

> 
> * A bug is fixed in ppc_linux_iterate_over_regset_sections in
>   ppc-linux-tdep.c, where the general-purpose registers were handled
>   incorrectly on 64-bit targets.

Haven't looked at the patches yet, but, since you haven't mentioned it, I feel
obliged to ask:  Any chance I could interest you in implementing the GDBserver
side bits?  We'd then be more assured the tdesc/regdat handling bits all fit
in place.  It should revolve around updating linux-s390-low.c:s390_arch_setup
to return the new description.  The hwcaps are already handy, with
s390_get_hwcap.  The series feels incomplete without some gdbserver love.  ;-)

Thanks again,
-- 
Pedro Alves

Re: [RFA PATCH v2 0/3] Add TDB regset support

[Andreas Arnez]

Pedro Alves <palves@redhat.com> writes:

> Haven't looked at the patches yet, but, since you haven't mentioned
> it, I feel obliged to ask: Any chance I could interest you in
> implementing the GDBserver side bits?  We'd then be more assured the
> tdesc/regdat handling bits all fit in place.  It should revolve around
> updating linux-s390-low.c:s390_arch_setup to return the new
> description.  The hwcaps are already handy, with s390_get_hwcap.  The
> series feels incomplete without some gdbserver love.  ;-)

Absolutely ;-)  Updated patch coming soon...