From: Yao Qi <yao@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Don't set dir separator if path has drive spec
Date: Tue, 04 Jun 2013 01:33:00 -0000 [thread overview]
Message-ID: <51AD4419.5000506@codesourcery.com> (raw)
In-Reply-To: <CADPb22Q+fBof0Rf7ZNng26TxBUe51sQgBohGDNDrcoz+kU4KHA@mail.gmail.com>
On 06/04/2013 08:48 AM, Doug Evans wrote:
>> - need_dir_separator = !IS_DIR_SEPARATOR (in_pathname[0]);
>> >+ need_dir_separator = (!IS_DIR_SEPARATOR (in_pathname[0])
>> >+ && !HAS_TARGET_DRIVE_SPEC (fskind, in_pathname));
>> >
>> > /* Cat the prefixed pathname together. */
>> > temp_pathname = concat (sysroot,
>
> Hi. Looks right to me.
Doug, thanks for the review. I check the indentation in Emacs and the
formatting looks right. Patch is committed.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-06-04 1:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 0:32 Yao Qi
2013-06-04 0:48 ` Doug Evans
2013-06-04 1:33 ` Yao Qi [this message]
2013-09-27 12:58 ` [PATCH] Fix regular /path/to/directory sysroots and target reported dll paths with drive specs. (was: Re: [PATCH] Don't set dir separator if path has drive spec) Pedro Alves
2013-09-27 14:18 ` [PATCH] Fix regular /path/to/directory sysroots and target reported dll paths with drive specs Yao Qi
2013-09-27 15:29 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AD4419.5000506@codesourcery.com \
--to=yao@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox