From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27563 invoked by alias); 4 Jun 2013 01:33:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27554 invoked by uid 89); 4 Jun 2013 01:33:42 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 04 Jun 2013 01:33:42 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Ujg84-0001y8-0j from Yao_Qi@mentor.com ; Mon, 03 Jun 2013 18:33:40 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 3 Jun 2013 18:33:40 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Mon, 3 Jun 2013 18:33:39 -0700 Message-ID: <51AD4419.5000506@codesourcery.com> Date: Tue, 04 Jun 2013 01:33:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Doug Evans CC: gdb-patches Subject: Re: [PATCH] Don't set dir separator if path has drive spec References: <1370306007-877-1-git-send-email-yao@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-06/txt/msg00031.txt.bz2 On 06/04/2013 08:48 AM, Doug Evans wrote: >> - need_dir_separator = !IS_DIR_SEPARATOR (in_pathname[0]); >> >+ need_dir_separator = (!IS_DIR_SEPARATOR (in_pathname[0]) >> >+ && !HAS_TARGET_DRIVE_SPEC (fskind, in_pathname)); >> > >> > /* Cat the prefixed pathname together. */ >> > temp_pathname = concat (sysroot, > > Hi. Looks right to me. Doug, thanks for the review. I check the indentation in Emacs and the formatting looks right. Patch is committed. -- Yao (齐尧)