From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove parse_print_values
Date: Fri, 31 May 2013 14:40:00 -0000 [thread overview]
Message-ID: <51A8B63A.5040903@redhat.com> (raw)
In-Reply-To: <1370009816-9119-1-git-send-email-yao@codesourcery.com>
On 05/31/2013 03:16 PM, Yao Qi wrote:
> * mi/mi-cmds.h (mi_no_values, mi_simple_values, mi_all_values):
> Remove the declarations.
> * mi/mi-parse.c: Moved from mi-cmd-var.c.
"Moved what?", he asks. :-)
* mi/mi-parse.c (XXX, YYY, ZZZ): Moved from mi-cmd-var.c.
> frame = get_selected_frame (NULL);
> - print_value = parse_print_values (argv[raw_arg]);
> + print_value = mi_parse_values_option (argv[raw_arg]);
Sorry to be picky, but the "mi_parse_values_option" naming to me
has a weaker connection with "enum print_values" than "parse_PRINT_VALUES".
I'd suggest calling the new shared function "mi_parse_print_values".
WDYT? This is fine with me with that change.
--
Pedro Alves
next prev parent reply other threads:[~2013-05-31 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 14:16 Yao Qi
2013-05-31 14:40 ` Pedro Alves [this message]
2013-06-03 3:18 ` Yao Qi
2013-06-03 11:36 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A8B63A.5040903@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox