From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5027 invoked by alias); 31 May 2013 14:40:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5018 invoked by uid 89); 31 May 2013 14:39:59 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 31 May 2013 14:39:59 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4VEdur7004960 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 31 May 2013 10:39:56 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4VEdtNB015876; Fri, 31 May 2013 10:39:56 -0400 Message-ID: <51A8B63A.5040903@redhat.com> Date: Fri, 31 May 2013 14:40:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove parse_print_values References: <1370009816-9119-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1370009816-9119-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg01109.txt.bz2 On 05/31/2013 03:16 PM, Yao Qi wrote: > * mi/mi-cmds.h (mi_no_values, mi_simple_values, mi_all_values): > Remove the declarations. > * mi/mi-parse.c: Moved from mi-cmd-var.c. "Moved what?", he asks. :-) * mi/mi-parse.c (XXX, YYY, ZZZ): Moved from mi-cmd-var.c. > frame = get_selected_frame (NULL); > - print_value = parse_print_values (argv[raw_arg]); > + print_value = mi_parse_values_option (argv[raw_arg]); Sorry to be picky, but the "mi_parse_values_option" naming to me has a weaker connection with "enum print_values" than "parse_PRINT_VALUES". I'd suggest calling the new shared function "mi_parse_print_values". WDYT? This is fine with me with that change. -- Pedro Alves