From: Christian Groessler <chris@groessler.org>
To: Tom Tromey <tromey@redhat.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>,
gdb@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [patch]: testsuite: run bash instead of sh when using brace expansion
Date: Tue, 21 May 2013 07:27:00 -0000 [thread overview]
Message-ID: <519B21C9.8030107@groessler.org> (raw)
In-Reply-To: <87a9npof57.fsf@fleche.redhat.com>
On 05/20/13 17:16, Tom Tromey wrote:
>
>> lappend dirs [join [list $r$x$comp$l$f]]
> My suggestion for "join" was really odd. I was confused...
> It is simpler to just use string concatenation like
>
> lappend dirs $r$x$comp$l$f
>
> The patch is ok with that change.
Committed.
Thanks,
chris
prev parent reply other threads:[~2013-05-21 7:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51936596.8010205@groessler.org>
[not found] ` <m3hai3kes8.fsf@redhat.com>
2013-05-17 7:45 ` Christian Groessler
2013-05-17 8:13 ` Joel Brobecker
2013-05-17 16:44 ` Tom Tromey
2013-05-17 22:57 ` Christian Groessler
2013-05-20 15:16 ` Tom Tromey
2013-05-21 7:27 ` Christian Groessler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B21C9.8030107@groessler.org \
--to=chris@groessler.org \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox