From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10850 invoked by alias); 21 May 2013 07:27:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10828 invoked by uid 89); 21 May 2013 07:27:20 -0000 X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MAY_BE_FORGED,RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from vigilia.groessler.org (HELO vigilia.groessler.org) (178.63.177.85) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 21 May 2013 07:27:19 +0000 Received: from [10.23.1.38] (gaga.groessler.org [212.168.189.235] (may be forged)) by vigilia.groessler.org (8.14.6/8.14.6) with ESMTP id r4L7RHtT011379 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Tue, 21 May 2013 09:27:18 +0200 (CEST) Message-ID: <519B21C9.8030107@groessler.org> Date: Tue, 21 May 2013 07:27:00 -0000 From: Christian Groessler User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Tom Tromey CC: Sergio Durigan Junior , gdb@sourceware.org, gdb-patches@sourceware.org Subject: Re: [patch]: testsuite: run bash instead of sh when using brace expansion References: <51936596.8010205@groessler.org> <5195E023.10203@groessler.org> <87a9ntr1xl.fsf@fleche.redhat.com> <5196B5CA.1000704@groessler.org> <87a9npof57.fsf@fleche.redhat.com> In-Reply-To: <87a9npof57.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00758.txt.bz2 On 05/20/13 17:16, Tom Tromey wrote: > >> lappend dirs [join [list $r$x$comp$l$f]] > My suggestion for "join" was really odd. I was confused... > It is simpler to just use string concatenation like > > lappend dirs $r$x$comp$l$f > > The patch is ok with that change. Committed. Thanks, chris