From: Pedro Alves <palves@redhat.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix gdb_assert caused by 'catch signal ...' and fork
Date: Fri, 17 May 2013 18:18:00 -0000 [thread overview]
Message-ID: <51967454.7000306@redhat.com> (raw)
In-Reply-To: <1368736234.2225.30.camel@soleil>
On 05/16/2013 09:30 PM, Philippe Waroquiers wrote:
>>> + (void) wait(NULL);
>> Missing space before parens. (do you really need the cast?)
> space added.
> I added the cast to explicitely show that the return value is ignored.
> I might instead not ignore it if you think this is needed/better.
IMO, that's more noise than signal. We ignore return values in
many many cases, and don't do that (including other wait calls in
the testsuite).
> I also added a comment in breakpoint.c, to explain why
> the bp_loc_other locations are not removed.
>
> Ok to apply ?
Looks good to me. Give it a couple days more, in case Doug or
others wants to comment, and check it in then.
Thanks,
--
Pedro Alves
next prev parent reply other threads:[~2013-05-17 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 21:56 Philippe Waroquiers
2013-05-10 16:39 ` Doug Evans
2013-05-10 17:18 ` Pedro Alves
2013-05-10 22:14 ` Philippe Waroquiers
2013-05-11 9:10 ` Pedro Alves
2013-05-10 17:20 ` Pedro Alves
2013-05-16 20:30 ` Philippe Waroquiers
2013-05-17 18:18 ` Pedro Alves [this message]
2013-05-21 18:49 ` Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51967454.7000306@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox