From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix gdb_assert caused by 'catch signal ...' and fork
Date: Tue, 21 May 2013 18:49:00 -0000 [thread overview]
Message-ID: <1369162155.2221.1.camel@soleil> (raw)
In-Reply-To: <51967454.7000306@redhat.com>
On Fri, 2013-05-17 at 19:17 +0100, Pedro Alves wrote:
> >>> + (void) wait(NULL);
> IMO, that's more noise than signal. We ignore return values in
> many many cases, and don't do that (including other wait calls in
> the testsuite).
Removed the '(void)'
>
> > I also added a comment in breakpoint.c, to explain why
> > the bp_loc_other locations are not removed.
> >
> > Ok to apply ?
>
> Looks good to me. Give it a couple days more, in case Doug or
> others wants to comment, and check it in then.
and committed.
Thanks
Philippe
prev parent reply other threads:[~2013-05-21 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 21:56 Philippe Waroquiers
2013-05-10 16:39 ` Doug Evans
2013-05-10 17:18 ` Pedro Alves
2013-05-10 22:14 ` Philippe Waroquiers
2013-05-11 9:10 ` Pedro Alves
2013-05-10 17:20 ` Pedro Alves
2013-05-16 20:30 ` Philippe Waroquiers
2013-05-17 18:18 ` Pedro Alves
2013-05-21 18:49 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369162155.2221.1.camel@soleil \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox