Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Phil Muldoon <pmuldoon@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch][python] 0 of 5 - Frame filters and Wrappers
Date: Thu, 16 May 2013 13:15:00 -0000	[thread overview]
Message-ID: <5194DBDE.2020903@redhat.com> (raw)
In-Reply-To: <20130516115001.GA6684@adacore.com>

On 16/05/13 12:50, Joel Brobecker wrote:
> Hi Phil,
> 
>> This patch-series has been committed in its entirety.  Thank you for
>> the reviews, it is very much appreciated.  I have attached the
>> ChangeLog entries as merged for committing the patch.
> 
> There is something I noticed while using a debugger where the gdb
> modules cannot be found:
> 
>   (gdb) bt
>   Python Exception <type 'exceptions.ImportError'> No module named gdb.frames: 
> 
> This is because I am using a debugger where python module path relocation
> is not working for some reason I am yet to investigate. But this would
> happen to someone improperly installing GDB as well.  This can actually
> happen fairly often, because it's usual in emergency situations to just
> copy the gdb binary where you need it instead of the full blown install,
> knowingly letting go of the Python capabilities when you don't need them.

We can, I have no real opinion.  In a case of an error importing that
module, we can set a flag to turn frame filters off.  While I am
sympathetic, this scenario should never really happen if GDB was
compiled and installed with Python. (Well, obviously it did in your
scenario ;) But that's another bug).

But this I think is the tip of the iceberg with an improperly
installed Python GDB.  I suspect pretty-printing will also suffer
failures, and other automatically instantiated Python bits within GDB.

Anyway, I'll write a patch to be more fault tolerant if nobody else
objects or has a differing opinion.

Cheers,

Phil



  reply	other threads:[~2013-05-16 13:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06  8:22 Phil Muldoon
2013-05-10 10:57 ` Phil Muldoon
2013-05-16 11:50   ` Joel Brobecker
2013-05-16 13:15     ` Phil Muldoon [this message]
2013-05-16 13:32       ` Tom Tromey
2013-05-16 13:35         ` Phil Muldoon
2013-07-17 20:27         ` Tom Tromey
2013-05-16 13:27     ` Tom Tromey
  -- strict thread matches above, loose matches on Subject: below --
2013-04-22 15:54 Phil Muldoon
2013-03-11 22:12 Phil Muldoon
2012-11-30 14:30 Phil Muldoon
2012-12-03 21:34 ` Tom Tromey
2012-12-05 12:31   ` Phil Muldoon
2012-12-05 17:36     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5194DBDE.2020903@redhat.com \
    --to=pmuldoon@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox