From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4148 invoked by alias); 16 May 2013 13:15:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4114 invoked by uid 89); 16 May 2013 13:15:17 -0000 X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 16 May 2013 13:15:15 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4GDFDMc023351 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 May 2013 09:15:13 -0400 Received: from localhost.localdomain (ovpn-112-16.ams2.redhat.com [10.36.112.16]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4GDFBt0010352; Thu, 16 May 2013 09:15:12 -0400 Message-ID: <5194DBDE.2020903@redhat.com> Date: Thu, 16 May 2013 13:15:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: Re: [patch][python] 0 of 5 - Frame filters and Wrappers References: <51876848.2020802@redhat.com> <518CD285.4040706@redhat.com> <20130516115001.GA6684@adacore.com> In-Reply-To: <20130516115001.GA6684@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00611.txt.bz2 On 16/05/13 12:50, Joel Brobecker wrote: > Hi Phil, > >> This patch-series has been committed in its entirety. Thank you for >> the reviews, it is very much appreciated. I have attached the >> ChangeLog entries as merged for committing the patch. > > There is something I noticed while using a debugger where the gdb > modules cannot be found: > > (gdb) bt > Python Exception No module named gdb.frames: > > This is because I am using a debugger where python module path relocation > is not working for some reason I am yet to investigate. But this would > happen to someone improperly installing GDB as well. This can actually > happen fairly often, because it's usual in emergency situations to just > copy the gdb binary where you need it instead of the full blown install, > knowingly letting go of the Python capabilities when you don't need them. We can, I have no real opinion. In a case of an error importing that module, we can set a flag to turn frame filters off. While I am sympathetic, this scenario should never really happen if GDB was compiled and installed with Python. (Well, obviously it did in your scenario ;) But that's another bug). But this I think is the tip of the iceberg with an improperly installed Python GDB. I suspect pretty-printing will also suffer failures, and other automatically instantiated Python bits within GDB. Anyway, I'll write a patch to be more fault tolerant if nobody else objects or has a differing opinion. Cheers, Phil