From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA/testsuite] Cleanup pending breakpoints
Date: Fri, 26 Apr 2013 20:46:00 -0000 [thread overview]
Message-ID: <517AC0CC.80406@redhat.com> (raw)
In-Reply-To: <517ABE65.1040809@redhat.com>
On 04/26/2013 06:50 PM, Keith Seitz wrote:
> On 04/26/2013 10:44 AM, Pedro Alves wrote:
>> If in the end, there's no use in the tree for an "allow-pending"
>> option that allows pending but doesn't fail with a regular
>> non-pending breakpoint, in addition to a new "pending" option that
>> _requires_ pending, then I'd rather eliminate "allow-pending".
>
> Right, that's what I meant -- remove "allow-pending" and add "pending". I suggest for the immediate time, we/I introduce "pending" (i.e, fail if regular BP set), and then we/I can go back and take a look at all the users of allow-pending and ascertain whether they would work (or were supposed to work) if a normal breakpoint was set.
>
> From the dozen cases or two that I've already looked at (or written), all were really of the required type not optional type, i.e., the test was written specifically for a pending breakpoint; a regular breakpoint would break the test.
Sounds like a good plan to me.
Thanks,
--
Pedro Alves
prev parent reply other threads:[~2013-04-26 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 12:20 Keith Seitz
2013-04-24 18:24 ` Pedro Alves
2013-04-26 11:37 ` Keith Seitz
2013-04-26 20:30 ` Pedro Alves
2013-04-26 20:45 ` Keith Seitz
2013-04-26 20:46 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517AC0CC.80406@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox