From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA/testsuite] Cleanup pending breakpoints
Date: Wed, 24 Apr 2013 18:24:00 -0000 [thread overview]
Message-ID: <5177EDAF.6030107@redhat.com> (raw)
In-Reply-To: <517716B5.7050406@redhat.com>
On 04/24/2013 12:18 AM, Keith Seitz wrote:
> Hi,
>
> Some types of pending breakpoints are commonly set by using gdb_test_multiple to respond to the "Make breakpoint pending?" question. This patch adds support for several breakpoint types to gdb_breakpoint so that the standard machinery can be used instead.
>
> I've also taken this opportunity to update the neglected documentation for gdb_breakpoint. AFAICT, "passfail" just appeared out of nowhere, and it has never been implemented/documented.
Whenever you feel compelled to say "also" in a patch description,
consider splitting the patch in two. ;-) Updating the documentation
part could go first, and would be clearly an improvement. Extending
the interface could go afterwards, and that patch would then actually
be clearer.
>
> Comments/questions?
I wonder whether "allow-pending" is the right option for the "pending" tests.
As in, "allow" != "require". I wonder whether we're losing test
coverage in those cases?
--
Pedro Alves
next prev parent reply other threads:[~2013-04-24 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 12:20 Keith Seitz
2013-04-24 18:24 ` Pedro Alves [this message]
2013-04-26 11:37 ` Keith Seitz
2013-04-26 20:30 ` Pedro Alves
2013-04-26 20:45 ` Keith Seitz
2013-04-26 20:46 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5177EDAF.6030107@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox