From: Yao Qi <yao@codesourcery.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,
Marc Khouzam <marc.khouzam@ericsson.com>
Subject: Re: [PATCH] Fix bug 15181 Missing continue on dprintf that defaults to "gdb" style from "agent"
Date: Mon, 22 Apr 2013 13:31:00 -0000 [thread overview]
Message-ID: <51748351.2030300@codesourcery.com> (raw)
In-Reply-To: <CANFwon0wo7REDHb7FFk59Qoty_i_-NAwErFSQw7TZJWtqWNWrg@mail.gmail.com>
On 04/21/2013 07:06 PM, Hui Zhu wrote:
> This patch is from Marc to fix
> http://sourceware.org/bugzilla/show_bug.cgi?id=15181
> I add a test for it.
Hui,
I am afraid that it is not correct to append "continue" command to
dprintf commands, considering PR 15075 dprintf inteferes with "next".
This patch <http://sourceware.org/ml/gdb-patches/2013-02/msg00736.html>
removes "continue" command from dprintf commands, and it is reasonable
to remove "continue", IMO. The patch is not perfect, as it disallows
users setting commands to dprintf, and I prefer to support commands in
dprintf, personally.
Since you are actively fixing dprintf bugs, feel free to take PR 15075
over, and fix it first. Then, PR 15181 may not be a bug at all.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-04-22 0:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 9:22 Hui Zhu
2013-04-22 13:31 ` Yao Qi [this message]
2013-04-23 17:53 ` Hui Zhu
2013-04-23 18:03 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51748351.2030300@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox