From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22072 invoked by alias); 22 Apr 2013 00:24:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22060 invoked by uid 89); 22 Apr 2013 00:24:44 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 22 Apr 2013 00:24:43 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UU4Yj-0001s4-KH from Yao_Qi@mentor.com ; Sun, 21 Apr 2013 17:24:41 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 21 Apr 2013 17:24:41 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Sun, 21 Apr 2013 17:24:26 -0700 Message-ID: <51748351.2030300@codesourcery.com> Date: Mon, 22 Apr 2013 13:31:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Hui Zhu CC: gdb-patches ml , Marc Khouzam Subject: Re: [PATCH] Fix bug 15181 Missing continue on dprintf that defaults to "gdb" style from "agent" References: In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-04/txt/msg00653.txt.bz2 On 04/21/2013 07:06 PM, Hui Zhu wrote: > This patch is from Marc to fix > http://sourceware.org/bugzilla/show_bug.cgi?id=15181 > I add a test for it. Hui, I am afraid that it is not correct to append "continue" command to dprintf commands, considering PR 15075 dprintf inteferes with "next". This patch removes "continue" command from dprintf commands, and it is reasonable to remove "continue", IMO. The patch is not perfect, as it disallows users setting commands to dprintf, and I prefer to support commands in dprintf, personally. Since you are actively fixing dprintf bugs, feel free to take PR 15075 over, and fix it first. Then, PR 15181 may not be a bug at all. -- Yao (齐尧)