From: Pedro Alves <palves@redhat.com>
To: Siva Chandra <sivachandra@google.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC][testsuite] Add option to link testcases with pthreads when using 'prepare_for_testing'
Date: Mon, 15 Apr 2013 18:51:00 -0000 [thread overview]
Message-ID: <516C0D67.7020307@redhat.com> (raw)
In-Reply-To: <CAGyQ6gx2aLH2_jGAB8e0_EwmCiypepq9EXn4mC6jp4ahZ+BiTg@mail.gmail.com>
On 04/15/2013 02:36 PM, Siva Chandra wrote:
> ChangeLog
> 2013-04-15 Siva Chandra Reddy <sivachandra@google.com>
>
> Add option to link testcases with Pthreads library when
> using 'prepare_for_testing' in tests.
Super nit, but do we need "with_" ? We don't say "with_debug" or
"with_nowarnings" either. I'd suggest just "pthread". Singular, as
GNU uses -pthread / -lpthread.
Thanks,
--
Pedro Alves
next prev parent reply other threads:[~2013-04-15 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 12:02 Siva Chandra
2013-04-15 9:22 ` Tom Tromey
2013-04-15 18:12 ` Siva Chandra
2013-04-15 18:51 ` Pedro Alves [this message]
2013-04-16 5:39 ` Siva Chandra
2013-04-16 5:47 ` Tom Tromey
2013-04-16 7:52 ` Siva Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516C0D67.7020307@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox