From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-100502-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12144 invoked by alias); 15 Apr 2013 14:23:41 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 12133 invoked by uid 89); 15 Apr 2013 14:23:40 -0000
X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 15 Apr 2013 14:23:40 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3FENbb9029776	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 15 Apr 2013 10:23:37 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3FENai2029077;	Mon, 15 Apr 2013 10:23:36 -0400
Message-ID: <516C0D67.7020307@redhat.com>
Date: Mon, 15 Apr 2013 18:51:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
MIME-Version: 1.0
To: Siva Chandra <sivachandra@google.com>
CC: Tom Tromey <tromey@redhat.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC][testsuite] Add option to link testcases with pthreads when using 'prepare_for_testing'
References: <CAGyQ6gyQ8+Txgam=W9+PCdFP1Uy_VHJrK3JM2pL=ZwpYVqjedA@mail.gmail.com>	<8761zrfox7.fsf@fleche.redhat.com> <CAGyQ6gx2aLH2_jGAB8e0_EwmCiypepq9EXn4mC6jp4ahZ+BiTg@mail.gmail.com>
In-Reply-To: <CAGyQ6gx2aLH2_jGAB8e0_EwmCiypepq9EXn4mC6jp4ahZ+BiTg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-04/txt/msg00428.txt.bz2

On 04/15/2013 02:36 PM, Siva Chandra wrote:

> ChangeLog
> 2013-04-15  Siva Chandra Reddy  <sivachandra@google.com>
> 
>         Add option to link testcases with Pthreads library when
>         using 'prepare_for_testing' in tests.

Super nit, but do we need "with_" ?  We don't say "with_debug" or
"with_nowarnings" either.  I'd suggest just "pthread".  Singular, as
GNU uses -pthread / -lpthread.

Thanks,
-- 
Pedro Alves