Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* Re: [patch] minor patch to constify lm_addr_check
  2013-04-08 19:44   ` Aleksandar Ristovski
@ 2013-04-08 17:28     ` Aleksandar Ristovski
  0 siblings, 0 replies; 3+ messages in thread
From: Aleksandar Ristovski @ 2013-04-08 17:28 UTC (permalink / raw)
  To: Jan Kratochvil, gdb-patches

On 13-04-08 09:52 AM, Jan Kratochvil wrote:
> On Mon, 08 Apr 2013 15:50:00 +0200, Aleksandar Ristovski wrote:
>>      Add const to lm_addr_check.
>>
>>          * solib-svr4.c (lm_addr_check): Add const qualifier to 'so' arg.
>
> Yes, this is OK, in fact such patch could be checked in as [obvious] (checked
> by rebuild).
>
>
> Thanks,
> Jan
>

Committed: http://sourceware.org/ml/gdb-cvs/2013-04/msg00074.html

Thank you,

Aleksandar


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] minor patch to constify lm_addr_check
       [not found] ` <20130408135218.GA15323@host2.jankratochvil.net>
@ 2013-04-08 19:44   ` Aleksandar Ristovski
  2013-04-08 17:28     ` Aleksandar Ristovski
  0 siblings, 1 reply; 3+ messages in thread
From: Aleksandar Ristovski @ 2013-04-08 19:44 UTC (permalink / raw)
  To: gdb-patches

On 13-04-08 09:52 AM, Jan Kratochvil wrote:
> On Mon, 08 Apr 2013 15:50:00 +0200, Aleksandar Ristovski wrote:
>>      Add const to lm_addr_check.
>>
>>          * solib-svr4.c (lm_addr_check): Add const qualifier to 'so' arg.
>
> Yes, this is OK, in fact such patch could be checked in as [obvious] (checked
> by rebuild).
>
>
> Thanks,
> Jan
>

Committed: http://sourceware.org/ml/gdb-cvs/2013-04/msg00074.html

Thank you,

Aleksandar


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [patch] minor patch to constify lm_addr_check
@ 2013-04-08 19:48 Aleksandar Ristovski
       [not found] ` <20130408135218.GA15323@host2.jankratochvil.net>
  0 siblings, 1 reply; 3+ messages in thread
From: Aleksandar Ristovski @ 2013-04-08 19:48 UTC (permalink / raw)
  To: gdb-patches

This has already been seen in the other patches, but I want it committed 
before the rest so I can finish with const-correct use of lm_addr_check.

Thanks,

Aleksandar


     Add const to lm_addr_check.

         * solib-svr4.c (lm_addr_check): Add const qualifier to 'so' arg.

diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index 601e34d..bb2a4e9 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -189,7 +189,7 @@ has_lm_dynamic_from_link_map (void)
  }

  static CORE_ADDR
-lm_addr_check (struct so_list *so, bfd *abfd)
+lm_addr_check (const struct so_list *so, bfd *abfd)
  {
    if (!so->lm_info->l_addr_p)
      {


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-04-08 16:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-08 19:48 [patch] minor patch to constify lm_addr_check Aleksandar Ristovski
     [not found] ` <20130408135218.GA15323@host2.jankratochvil.net>
2013-04-08 19:44   ` Aleksandar Ristovski
2013-04-08 17:28     ` Aleksandar Ristovski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox