Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>, gdb-patches@sourceware.org
Subject: Re: Update dg-extract-results.* from gcc
Date: Tue, 07 Aug 2018 14:35:00 -0000	[thread overview]
Message-ID: <515bfbff-e2f7-3574-2726-ee1592786891@redhat.com> (raw)
In-Reply-To: <yddh8ku2mrc.fsf@CeBiTec.Uni-Bielefeld.DE>

On 07/20/2018 12:02 PM, Rainer Orth wrote:
> When looking at the gdb.sum file produced by dg-extract-results.sh on
> Solaris 11/x86, I noticed some wrong sorting, like this:
> 
> PASS: gdb.ada/addr_arith.exp: print something'address + 0
> PASS: gdb.ada/addr_arith.exp: print 0 + something'address
> PASS: gdb.ada/addr_arith.exp: print something'address - 0
> PASS: gdb.ada/addr_arith.exp: print 0 - something'address
> 
> Looking closer, I noticed that while dg-extract-results.sh had been
> copied over from contrib in the gcc repo, the corresponding
> dg-extract-results.py file had not.  The latter not only fixes the
> sorting problem I'd observed, but is also way faster than the shell
> version (like a factor of 50 faster).

We used to have the dg-extract-results.py file, but we deleted it
because it caused (funnily enough, sorting) problems.  See:

  https://sourceware.org/ml/gdb-patches/2015-02/msg00333.html

Has that sorting stability issue been meanwhile fixed upstream?

Thanks,
Pedro Alves


  parent reply	other threads:[~2018-08-07 14:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 11:02 Rainer Orth
2018-07-25 19:08 ` Tom Tromey
2018-07-26 20:54   ` Sergio Durigan Junior
2018-07-31 12:46     ` Rainer Orth
2018-07-31 12:44   ` Rainer Orth
2018-08-06 13:50     ` Rainer Orth
2018-08-07 11:52     ` Rainer Orth
2018-08-07 14:35 ` Pedro Alves [this message]
2018-08-08 14:36   ` Rainer Orth
2018-08-08 15:24     ` Pedro Alves
2018-10-01  9:36       ` dg-extract-results's bad sorting behavior (Re: Update dg-extract-results.* from gcc) Pedro Alves
2018-09-11 11:02 ` [obv] Fix dg-extract-results.sh path [Re: Update dg-extract-results.* from gcc] Jan Kratochvil
2018-09-11 11:03 ` Missing toplevel contrib/ in gdb-*.tar.xz " Jan Kratochvil
2018-09-11 11:20   ` Rainer Orth
2018-09-11 12:01     ` Joel Brobecker
2018-09-12  5:21       ` [PATCH] Add "contrib" to the list of GDB support dirs (on src-release.sh) Sergio Durigan Junior
2018-09-13 14:26         ` Tom Tromey
2018-09-13 16:35           ` Sergio Durigan Junior
2018-09-12  5:23       ` Missing toplevel contrib/ in gdb-*.tar.xz [Re: Update dg-extract-results.* from gcc] Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515bfbff-e2f7-3574-2726-ee1592786891@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox