From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>, gdb-patches@sourceware.org
Subject: Re: [patch 1/2+7.6] /proc/PID/smaps: filename fix
Date: Fri, 05 Apr 2013 19:51:00 -0000 [thread overview]
Message-ID: <515F184F.2000003@redhat.com> (raw)
In-Reply-To: <20130329202737.GA6075@host2.jankratochvil.net>
On 03/29/2013 08:27 PM, Jan Kratochvil wrote:
> On Fri, 29 Mar 2013 21:24:38 +0100, Andreas Schwab wrote:
>> Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>>
>>> currently GDB complains:
>>> warning: Error parsing {s,}maps file '[heap]'
>>> warning: Error parsing {s,}maps file '/usr/lib64/libc-2.17.so'
>>>
>>> which is sure incorrect, it should have been:
>>> warning: Error parsing {s,}maps file '/proc/30100/smaps'
>>> warning: Error parsing {s,}maps file '/proc/30100/smaps'
>>
>> Which mean you'll no longer know what's wrong with it.
The current warning doesn't actually show what failed to parse.
We'd need to print the line for that.
>
> I believe the second output was originally intended, this is what this patch
> tries to fix.
I agree.
>
> It may not be perfect but it only tries to suggest what is that "{s,}maps
> file". I did not write this code (although reviewed it IIRC).
--
Pedro Alves
next prev parent reply other threads:[~2013-04-05 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-31 17:43 Jan Kratochvil
2013-03-31 17:43 ` Andreas Schwab
[not found] ` <20130329202737.GA6075@host2.jankratochvil.net>
2013-04-05 19:51 ` Pedro Alves [this message]
2013-04-05 20:20 ` [commit+7.6] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515F184F.2000003@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox