From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3244 invoked by alias); 5 Apr 2013 18:30:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3201 invoked by uid 89); 5 Apr 2013 18:30:51 -0000 X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 05 Apr 2013 18:30:48 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r35IUiGJ025919 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 5 Apr 2013 14:30:44 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r35IUdvd026419; Fri, 5 Apr 2013 14:30:39 -0400 Message-ID: <515F184F.2000003@redhat.com> Date: Fri, 05 Apr 2013 19:51:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Jan Kratochvil CC: Andreas Schwab , gdb-patches@sourceware.org Subject: Re: [patch 1/2+7.6] /proc/PID/smaps: filename fix References: <20130329195301.GA3502@host2.jankratochvil.net> <20130329202737.GA6075@host2.jankratochvil.net> In-Reply-To: <20130329202737.GA6075@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00138.txt.bz2 On 03/29/2013 08:27 PM, Jan Kratochvil wrote: > On Fri, 29 Mar 2013 21:24:38 +0100, Andreas Schwab wrote: >> Jan Kratochvil writes: >> >>> currently GDB complains: >>> warning: Error parsing {s,}maps file '[heap]' >>> warning: Error parsing {s,}maps file '/usr/lib64/libc-2.17.so' >>> >>> which is sure incorrect, it should have been: >>> warning: Error parsing {s,}maps file '/proc/30100/smaps' >>> warning: Error parsing {s,}maps file '/proc/30100/smaps' >> >> Which mean you'll no longer know what's wrong with it. The current warning doesn't actually show what failed to parse. We'd need to print the line for that. > > I believe the second output was originally intended, this is what this patch > tries to fix. I agree. > > It may not be perfect but it only tries to suggest what is that "{s,}maps > file". I did not write this code (although reviewed it IIRC). -- Pedro Alves