[patch] fix remote-host fails in gdb.cp/cplabel.exp

[patch] fix remote-host fails in gdb.cp/cplabel.exp

[Sandra Loosemore]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

This 1-character patch is very similar to this already-approved one:

http://sourceware.org/ml/gdb-patches/2013-04/msg00053.html

It fixes the regexp in the testcase to allow the test to pass when the 
file is compiled without a directory prefix in remote-host testing.

OK to commit?

-Sandra


2013-04-03  Sandra Loosemore  <sandra@codesourcery.com>

	gdb/testsuite/

	* gdb.cp/cplabel.exp: Fix regexp to allow tests to pass on
	remote hosts.

[-- Attachment #2: cplabel.patch --]
[-- Type: text/x-patch, Size: 631 bytes --]

Index: gdb/testsuite/gdb.cp/cplabel.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/cplabel.exp,v
retrieving revision 1.3
diff -u -p -r1.3 cplabel.exp
--- gdb/testsuite/gdb.cp/cplabel.exp	1 Jan 2013 06:33:27 -0000	1.3
+++ gdb/testsuite/gdb.cp/cplabel.exp	4 Apr 2013 01:30:12 -0000
@@ -35,6 +35,6 @@ foreach m $methods {
     foreach l $labels {
 	set line [gdb_get_line_number "$m:$l"]
 	gdb_test "break foo::$m:$l" \
-	    "Breakpoint $decimal at $hex: file .*/$srcfile, line $line\."
+	    "Breakpoint $decimal at $hex: file .*$srcfile, line $line\."
     }
 }

Re: [patch] fix remote-host fails in gdb.cp/cplabel.exp

[Pedro Alves]

On 04/04/2013 02:36 AM, Sandra Loosemore wrote:
> 
> 
> 2013-04-03  Sandra Loosemore  <sandra@codesourcery.com>
> 
>     gdb/testsuite/
> 
>     * gdb.cp/cplabel.exp: Fix regexp to allow tests to pass on
>     remote hosts.

That's a "why", not a "what", but we can leave a short why in the
header if you like.  Modelling from your other patch, something like:

2013-04-03  Sandra Loosemore  <sandra@codesourcery.com>

	Tweak regexp to allow tests to pass on remote hosts.

	* gdb.cp/cplabel.exp: Allow empty directory in
	file reported for breakpoint location.

The patch itself is okay.

Thanks,
-- 
Pedro Alves